Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ASM mode var description #910

Merged
merged 6 commits into from
Jun 25, 2021
Merged

fix: update ASM mode var description #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
551a15d
update key_file variable name and upgrade mode
cloud-pharaoh May 26, 2021
d4fb96b
Merge branch 'master' into master
bharathkkb Jun 3, 2021
8fb1e8a
Merge branch 'master' into master
bharathkkb Jun 4, 2021
82a7f83
Merge branch 'master' into master
morgante Jun 7, 2021
e4ac73d
revert key_file rename
cloud-pharaoh Jun 16, 2021
7f5fd64
Merge branch 'master' into master
bharathkkb Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/asm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ To deploy this config:
| key\_file | The GCP Service Account credentials file path used to deploy ASM. | `string` | `""` | no |
| location | The location (zone or region) this cluster has been created in. | `string` | n/a | yes |
| managed\_control\_plane | ASM managed control plane boolean. Determines whether to install ASM managed control plane. Installing ASM managed control plane does not install gateways. Documentation on how to install gateways with ASM MCP can be found at https://cloud.google.com/service-mesh/docs/managed-control-plane#install_istio_gateways_optional. | `bool` | `false` | no |
| mode | ASM mode for deployment. Supported mode is `install` only. | `string` | `"install"` | no |
| mode | ASM mode for deployment. Supported modes are `install` and `upgrade`. | `string` | `"install"` | no |
| options | Comma separated list of options. Works with in-cluster control plane only. Supported options are documented in https://cloud.google.com/service-mesh/docs/enable-optional-features. | `list` | `[]` | no |
| outdir | Sets `--outdir` option. | `string` | `"none"` | no |
| project\_id | The project in which the resource belongs. | `string` | n/a | yes |
Expand Down
2 changes: 1 addition & 1 deletion modules/asm/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ variable "asm_git_tag" {
}

variable "mode" {
description = "ASM mode for deployment. Supported mode is `install` only."
description = "ASM mode for deployment. Supported modes are `install` and `upgrade`."
type = string
default = "install"
}
Expand Down