Set horizontal_pod_autoscaling to true by default #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkubaczyk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
|
I think this is a reasonable suggestion and change. One ask: could you add a note to the |
|
@morgante done. :-) |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Set horizontal_pod_autoscaling to true by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to do a step further with #42 issue reported recently. It might be considered a cosmetic change, but I deeply believe following the standards from the
google_container_clusterresource is more than appropriate.The choose of
falsecomes from 21ec8db which is the very first commit from this module, hence this might be worth updating.Fixes #42.