feat(TPG>=7.0)!: adding default_compute_class_enabled

[rs1986x]

Hi

i have added the default_compute_class_enabled parameter. it is supported since version 7 of the provider so it's all good. the test fail in some examples because other dependency modules (e.g. project factory) have not yet updated to version 7 and for that reason it uses still provider 6.x

[apeabody]

i have added the default_compute_class_enabled parameter. it is supported since version 7 of the provider so it's all good. the test fail in some examples because other dependency modules (e.g. project factory) have not yet updated to version 7 and for that reason it uses still provider 6.x

Thanks @rs1986x - Can you also please bump the minimum TPG constraint as appropriate, that will make the version constraint failure clear rather than unknown default_compute_class_enabled field errors: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/autogen/main/versions.tf.tmpl#L27

Also, https://github.com/terraform-google-modules/terraform-google-project-factory/releases/tag/v18.1.0, now includes support for TPG v7. :)

[rs1986x]

i have added the default_compute_class_enabled parameter. it is supported since version 7 of the provider so it's all good. the test fail in some examples because other dependency modules (e.g. project factory) have not yet updated to version 7 and for that reason it uses still provider 6.x

Thanks @rs1986x - Can you also please bump the minimum TPG constraint as appropriate, that will make the version constraint failure clear rather than unknown default_compute_class_enabled field errors: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/main/autogen/main/versions.tf.tmpl#L27

Also, https://github.com/terraform-google-modules/terraform-google-project-factory/releases/tag/v18.1.0, now includes support for TPG v7. :)

Hi @apeabody thanks for the comment, is there anything else you would require before merging the PR? thanks

[apeabody]

/gcbrun

[apeabody]

Probably wait for v40 for TPG>=7

[rs1986x]

Probably wait for v40 for TPG>=7

No problem. For now i am using my fork, i imagine that eventually somebody would have made the same change i have made but if it can help speed up the release why not. Let me know if you require any other change, in the meantime thanks again and i look forward to see the default class parameter in the main modules

[apeabody]

/gcbrun

[apeabody]

At a minimum this PR is needed first: #2446

[apeabody]

/gcbrun

[apeabody]

Currently waiting on terraform-google-modules/terraform-google-bastion-host#231

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[apeabody]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces the default_compute_class_enabled parameter, which requires bumping the Google provider version to >=7.0.0. The changes are consistently applied across the main module and its submodules. I've identified a potential issue in non-autopilot clusters where default_compute_class_enabled is set unconditionally, which could lead to errors if autoscaling is disabled. I've provided suggestions to make this setting conditional for improved robustness. The rest of the changes, including documentation and metadata updates, look good.

[apeabody]

Thanks for the contribution @rs1986x!

[RuiSMagalhaes]

description is misleading, no? I believe this has nothing to do with SPOT vms?

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#default_compute_class_enabled-1

@rs1986x @apeabody