Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added remote fleet support for anthos modules #1981

Conversation

CPL-markus
Copy link
Contributor

It should be possible to enable the ACM feature on a GKE cluster that has its fleet in a separate project.

Therefore an additonal variable hub_project_id was introduced to reference the fleet project id. If it is empty (default), the project_id variable will be used instead.

tuunit and others added 30 commits January 3, 2023 11:02
…ation-toolkit/infra/blueprint-test to v0.4.1 (terraform-google-modules#1534)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…in /test/integration (terraform-google-modules#1538)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ules#1498)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: Bharath KKB <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Andrew Peabody <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@CPL-markus CPL-markus requested review from ericyz, gtsorbo and a team as code owners June 20, 2024 12:49
Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @CPL-markus!

Can you please make your change in the source template as described here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/acm/README.md /tmp/tmp.AIQao951VV/workspace/modules/acm/README.md
91a92
> | hub\_project\_id | The project in which the GKE Hub belongs. Defaults to GKE cluster project\_id. | `string` | `""` | no |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
/usr/local/bin/task_helper_functions.sh: line 30: DELETE_AT_EXIT: readonly variable
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/acm/README.md /tmp/tmp.mBX4FUQN9b/generate_docs/workspace/modules/acm/README.md
91a92
> | hub\_project\_id | The project in which the GKE Hub belongs. Defaults to GKE cluster project\_id. | `string` | `""` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

SavvasM1 and others added 11 commits June 25, 2024 08:21
…in /test/integration (terraform-google-modules#1983)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…s#1993)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…com:WALTER-GROUP/terraform-google-kubernetes-engine into feature/anthos_modules_remote_fleet_project
@CPL-markus CPL-markus closed this Jul 15, 2024
@CPL-markus CPL-markus force-pushed the feature/anthos_modules_remote_fleet_project branch from 9042c2c to 7997e79 Compare July 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.