-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added remote fleet support for anthos modules #1981
Closed
CPL-markus
wants to merge
1,713
commits into
terraform-google-modules:master
from
WALTER-GROUP:feature/anthos_modules_remote_fleet_project
Closed
Added remote fleet support for anthos modules #1981
CPL-markus
wants to merge
1,713
commits into
terraform-google-modules:master
from
WALTER-GROUP:feature/anthos_modules_remote_fleet_project
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Zhao <[email protected]>
Co-authored-by: Eric Zhao <[email protected]>
…ation-toolkit/infra/blueprint-test to v0.4.1 (terraform-google-modules#1534) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…in /test/integration (terraform-google-modules#1538) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ules#1498) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…orm-google-modules#1530) Co-authored-by: Tolsee <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Peabody <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Andrew Peabody <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bharath KKB <[email protected]>
…e-modules#1556) Signed-off-by: Gari Singh <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Akshay Bathija <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Akshay Bathija <[email protected]> Co-authored-by: Bharath KKB <[email protected]>
Co-authored-by: Andrew Spiers <[email protected]>
…ine/google to v31 (terraform-google-modules#1966) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ation-toolkit/infra/blueprint-test to v0.15.1 (terraform-google-modules#1963) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ules#1970) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…er_network_tag to autopilot cluster network_tags if firewalls are toggled on (terraform-google-modules#1817) Co-authored-by: Andrew Peabody <[email protected]>
…google-modules#1969) Co-authored-by: Andrew Peabody <[email protected]>
apeabody
requested changes
Jun 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @CPL-markus!
Can you please make your change in the source template as described here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating
Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/acm/README.md /tmp/tmp.AIQao951VV/workspace/modules/acm/README.md
91a92
> | hub\_project\_id | The project in which the GKE Hub belongs. Defaults to GKE cluster project\_id. | `string` | `""` | no |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
/usr/local/bin/task_helper_functions.sh: line 30: DELETE_AT_EXIT: readonly variable
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/acm/README.md /tmp/tmp.mBX4FUQN9b/generate_docs/workspace/modules/acm/README.md
91a92
> | hub\_project\_id | The project in which the GKE Hub belongs. Defaults to GKE cluster project\_id. | `string` | `""` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
…in /test/integration (terraform-google-modules#1983) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…orm-google-modules#1962) Co-authored-by: Andrew Peabody <[email protected]>
…s#1993) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…com:WALTER-GROUP/terraform-google-kubernetes-engine into feature/anthos_modules_remote_fleet_project
…of service project
9042c2c
to
7997e79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to enable the ACM feature on a GKE cluster that has its fleet in a separate project.
Therefore an additonal variable
hub_project_id
was introduced to reference the fleet project id. If it is empty (default), theproject_id
variable will be used instead.