-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting for use with latest providers #144
Adapting for use with latest providers #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! LGTM, but can you verify whether this is a breaking change for existing clusters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like upgrades are breaking and CI is failing.
…tial_node_count into zonal clusters to align with regional
dbfdc09
to
3de1c26
Compare
2ce8e10
to
190bff9
Compare
c11d2cd
to
b6f6bad
Compare
01b9516
to
2604a96
Compare
2604a96
to
be06a79
Compare
We're in a conflicting state here and since my current client is not looking to even use this module, it's exceedingly difficult to find the time to follow through. If that decision changes (through pain) or some time clears up, I'll revisit this work. |
What's in this change?
node_pool
inline block in favor of the now supportedinitial_node_count
.location
instead ofzone
orregion
to get remove deprecation warnings.combine_docfiles.py
with upstream.Why make the change?
The motivation here started with being unable to use the module as is at the v2.0.0 release. The
node-pool
inline block was the source of this error:Replacing
zone
andregion
withlocation
was motivated by wanting to resolve deprecation warnings:Note: With the new
location
attribute available, it's possible (though a breaking change) we could also move both regional and zonal clusters and pools to be the same resources rather than spread them across two flavors. I didn't do that here because it's rather impactful but potentially a direction to take this next in simplifying.Fixes #143