Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add autoscaling profiles to non beta submodules #1820

Closed
froblesmartin opened this issue Dec 18, 2023 · 0 comments · Fixed by #1839
Closed

Feature: Add autoscaling profiles to non beta submodules #1820

froblesmartin opened this issue Dec 18, 2023 · 0 comments · Fixed by #1839
Labels
enhancement New feature or request

Comments

@froblesmartin
Copy link

TL;DR

Since hashicorp/terraform-provider-google#16653 was merged and https://github.com/hashicorp/terraform-provider-google/releases/tag/v5.9.0 released, now the autoscaling_profile is GA and available out of BETA.

I think it should be basically to do the same as #456 but in the non beta modules.

This week I don't have that much time, but if no one has done it in the next weeks, I will probably open a PR with the changes.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#autoscaling_profile

Detailed design

No response

Additional information

No response
@froblesmartin froblesmartin added the enhancement New feature or request label Dec 18, 2023
florianmutter added a commit to florianmutter/terraform-google-kubernetes-engine that referenced this issue Jan 10, 2024
@florianmutter
GKE autoscaling profile is GA now
5ee09a3 
Closes terraform-google-modules#1820
@florianmutter florianmutter mentioned this issue Jan 10, 2024
Merged
florianmutter added a commit to florianmutter/terraform-google-kubernetes-engine that referenced this issue Jan 10, 2024
@florianmutter
GKE autoscaling profile is GA now
606fcd2 
Closes terraform-google-modules#1820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(TPG>=5.9)!: cluster autoscaling profile is GA florianmutter/terraform-google-kubernetes-engine
1 participant
@froblesmartin