Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Update min provider to TPG ~> 3.44, CI fixes #91

Merged
merged 1 commit into from
Apr 21, 2022
Merged

fix!: Update min provider to TPG ~> 3.44, CI fixes #91

merged 1 commit into from
Apr 21, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Apr 20, 2022 •
edited
Loading

Closes #88
Closes #92
Closes #93

@comment-bot-dev
Copy link

comment-bot-dev commented Apr 20, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@apeabody apeabody changed the title fix: replace deprecated xip.io with nip.io Updates to unblock CI Apr 20, 2022
@apeabody apeabody changed the title Updates to unblock CI Updates to unblock CI with enabled TPG Apr 20, 2022
@apeabody apeabody changed the title Updates to unblock CI with enabled TPG Updates to unblock CI with current TPG Apr 20, 2022
@apeabody apeabody changed the title Updates to unblock CI with current TPG Updates to CI for current TPG version Apr 20, 2022
@apeabody apeabody changed the title Updates to CI for current TPG version Updates to enable CI for TPG ~> 3.44 Apr 21, 2022
@apeabody apeabody marked this pull request as ready for review April 21, 2022 00:39
bharathkkb
bharathkkb requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @apeabody

Makefile Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
examples/simple_example/variables.tf Outdated Show resolved Hide resolved
@apeabody
feat!: misc updates to support TPG ~> 3.44
42381fb 
fix: replace deprecated xip.io with nip.io for CI test
@bharathkkb bharathkkb changed the title Updates to enable CI for TPG ~> 3.44 fix!: Update min provider to TPG ~> 3.44, CI fixes Apr 21, 2022
@apeabody apeabody merged commit 1971baa into terraform-google-modules:master Apr 21, 2022
@apeabody apeabody deleted the fix-i88 branch April 21, 2022 15:57
@release-please release-please bot mentioned this pull request Apr 21, 2022
Merged
@apeabody apeabody mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@apeabody @comment-bot-dev @bharathkkb