Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add connection metadata #337

Merged
merged 3 commits into from
Sep 4, 2024
Merged

chore: Add connection metadata #337

merged 3 commits into from
Sep 4, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Sep 2, 2024 •
edited by apeabody
Loading

This PR makes below changes,

  1. Regenerate the metadata in current format. The current metadata is old and not in the current format.
  2. Add new connection metadata for incoming connection from cloud-run module

@q2w q2w force-pushed the chore/connection-metadata branch from f04f31a to 23a4bae Compare September 2, 2024 09:40
q2w
q2w commented Sep 2, 2024
View reviewed changes
@q2w q2w requested a review from bharathkkb September 2, 2024 12:22
@q2w q2w marked this pull request as ready for review September 2, 2024 12:22
@q2w q2w requested a review from a team as a code owner September 2, 2024 12:22
apeabody
apeabody reviewed Sep 3, 2024
View reviewed changes
@apeabody
Copy link
Contributor

apeabody commented Sep 3, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Sep 4, 2024

/gcbrun

apeabody
apeabody approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @q2w!

Validated this is now a chore.

@apeabody apeabody changed the title chore: Add connection metadata and update for_each expression to work with non-static member input chore: Add connection metadata Sep 4, 2024
@apeabody apeabody merged commit d5f6ec4 into terraform-google-modules:master Sep 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@q2w @apeabody @bharathkkb