feat!: soft-delete configuration

[SHA65536]

Closes #301
I'm new to contributing so I hope I did all that is needed
Tested this on our infra

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[bharathkkb]

Thanks for the PR @SHA65536. Could you also update the min provider to 5.22 https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/versions.tf#L23

[SHA65536]

@bharathkkb Let me know if there's something else I need to do? I don't know how to properly update the metadata

[bharathkkb]

/gcbrun

[jdub55]

@bharathkkb can you help explain the reason for min provider 5.22 for this change? Can this be backported to a 4.x version of the provider? Can we get this change backported to 4.x ? IHAC that is using 4.x of the provider and they need this change to be implemented on 4.x as otherwise they will need to upgrade to 5.x of the provider which will be a large and cumbersome task.

[SHA65536]

This option does not exist on 4.x and defaults to a retention of 7 days, which will result in additional costs starting august

[victorcadena]

@SHA65536 it looks like it does for version 4.85.0, or is this a bug in the docs? https://registry.terraform.io/providers/hashicorp/google/4.85.0/docs/resources/storage_bucket#soft_delete_policy

[SHA65536]

@victorcadena Hey, 4.85.0 came out 6 days ago, and they added the soft delete policy to there (2 months after the original pr, and 1 week after my last comment)
That means we no longer need 5.x as minimum version
Feel free to open a PR reducing the minimum version :)

[victorcadena]

#321

Let me know if it is that simple or there are more considerations! @SHA65536

[SHA65536]

Actually just noticed, the early 5.x versions (until 5.22) don't have soft delete, so I don't know how can we force >4.85 while also having <5.22
Maybe one of the maintainers can decide