-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add support for custom_placement_config #231
feat!: add support for custom_placement_config #231
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Forced push to use private email account. |
/gcbrun |
Hi @johnksv - Thanks for the contribution, some relevant INT output:
|
And removed custom_placement_config from multiple_buckets example since lifecycle rules storage class was set to MULTI_REGIONAL, which collides with this setup (which is dual region)
Hi @apeabody |
/gcbrun |
Merged main into this branch. |
/gcbrun |
Hi again, @apeabody |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @johnksv! Quick Questions on one section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @johnksv!
Add support for custom_placement_config which was added to provider in version 4.40.0.
custom_placement_config
is used for dual-region bucket configuration.Docs for custom_placement_config: https://registry.terraform.io/providers/hashicorp/google/4.56.0/docs/resources/storage_bucket#custom_placement_config