Include name of bucket as label for cost analysis #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
approved these changes
Nov 7, 2019
|
my pleasure @morgante ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we create numerous buckets with a single instance of this module they will all have the same labels as it stands today.
When exporting cost metrics to bigquery we may want to distinguish the cost per bucket.
When performing cost queries, labels are the way to group resources today (unfortunately we cannot query on bucket name), adding the unique name as a label is a good way to perform a query on a single bucket with regards to its' cost. Until Big Query cost analysis let's us query on the bucket name, this is a workaround.
Thoughts?