Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for custom_placement_config #231

Merged
merged 3 commits into from
Mar 21, 2023
Merged

feat!: add support for custom_placement_config #231

merged 3 commits into from
Mar 21, 2023

Conversation

johnksv
Copy link
Contributor

@johnksv johnksv commented Mar 9, 2023

Add support for custom_placement_config which was added to provider in version 4.40.0.

custom_placement_config is used for dual-region bucket configuration.

Docs for custom_placement_config: https://registry.terraform.io/providers/hashicorp/google/4.56.0/docs/resources/storage_bucket#custom_placement_config

@johnksv johnksv requested a review from a team as a code owner March 9, 2023 14:48
@google-cla
Copy link

google-cla bot commented Mar 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@johnksv
Copy link
Contributor Author

johnksv commented Mar 9, 2023

Forced push to use private email account.
Google Individual Contributor License Agreement signed.

@apeabody
Copy link
Contributor

apeabody commented Mar 9, 2023

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Mar 9, 2023

Hi @johnksv - Thanks for the contribution, some relevant INT output:

Error: googleapi: Error 400: Project - may not create storageClass MULTI_REGIONAL buckets with locationConstraint EU and data_location europe-north1, data_location europe-west1.., invalid

And removed custom_placement_config from multiple_buckets example since lifecycle rules storage class was set to MULTI_REGIONAL, which collides with this setup (which is dual region)
@johnksv
Copy link
Contributor Author

johnksv commented Mar 10, 2023

Hi @apeabody
Thanks.
I updated the example in simple bucket instead of multiple_buckets, due to the lifecycle in multiple_buckets causing collision with dual region/custom_placement_config setup.

@apeabody
Copy link
Contributor

/gcbrun

@johnksv
Copy link
Contributor Author

johnksv commented Mar 15, 2023

Merged main into this branch.
Please let me know if you would like it to be a rebase instead.

@apeabody
Copy link
Contributor

/gcbrun

@johnksv
Copy link
Contributor Author

johnksv commented Mar 19, 2023

Hi again, @apeabody
Anything missing from this getting merged? Thanks!

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @johnksv! Quick Questions on one section.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @johnksv!

@apeabody apeabody merged commit a0bbdbd into terraform-google-modules:master Mar 21, 2023
@johnksv johnksv deleted the feat/add-custom-placement-config branch March 23, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants