Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add router_keepalive_interval input var #66

Merged
merged 2 commits into from
Mar 29, 2022
Merged

add router_keepalive_interval input var #66

merged 2 commits into from
Mar 29, 2022

Conversation

robgordon89
Copy link
Contributor

@comment-bot-dev
Copy link

comment-bot-dev commented Mar 17, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@gangsta
Copy link

gangsta commented Mar 29, 2022

+1
or we need to merge this PR, or we need to add lifecycle to ignore changes of keepalive_interval

@morgante morgante merged commit 8409e80 into terraform-google-modules:master Mar 29, 2022
@release-please release-please bot mentioned this pull request Mar 29, 2022
Merged
@gangsta
Copy link

gangsta commented Mar 30, 2022

Thanks @morgante for help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robgordon89 @comment-bot-dev @gangsta @morgante