Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap network cleanup #375

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#13275
fixes hashicorp/terraform-provider-google#13276

This change clarifies the way bootstrapped networks are intended to be used, and cleans up areas where we currently use them. In short, we almost always use these to avoid quota issues with service_networking_connections, and when we do that, we cannot be reusing the testId across tests.

NOTE: After merging, we will want to clean up the bootstrapped networks that are no longer in use from all projects:

  • alloydb
  • vertex

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#7367

* Update bootstrapped networks for alloydb

* Update bootstrapped networks for redis

* Update bootstrapped networks for vertexai

* Update comment for BootstrapSharedTestNetwork to be more clear

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit de8d40b into terraform-google-modules:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccAlloydbBackup_alloydbBackupFullExample Failing test(s): TestAccAlloydbBackup_update
1 participant