Skip to content

Conversation

@wertlex
Copy link
Contributor

@wertlex wertlex commented May 20, 2024

Hey guys!

Recently introduced Private docker image support: https://railway.app/changelog/2024-03-15-template-composer
I was able communicate with them, so they kindly provided a way use pass credentials for private docker registries over public API.

This PR is actually makes this possible using Terraform.

In regards of PR

  • actual changes I made are just that
  • all the rest is pulling fresh GraphQL SDL and regenerating data types just a little bit

Note

  • unfortunately private docker registry support is only available for Pro plan users. It is restriction of Railway, not Terraform provider

@pksunkara
Copy link
Contributor

I don't think this is a full implementation because you haven't updated the graphql and logic for reading these props.

I think I need to ask railway people to upgrade my account to Pro so that I can add tests for this and support it.

@pksunkara pksunkara added D2: medium Difficulty: Medium to implement T: feature Type: Feature request U2: nice to have Urgency: Nice to have W: other Waiting: Other issues C: service Context: Service labels May 24, 2024
@wertlex
Copy link
Contributor Author

wertlex commented May 25, 2024

I don't think this is a full implementation because you haven't updated the graphql and logic for reading these props.

Unfortunately this is most recent graphql and these properties are write-only.
However, it's still a good point. I have to check if there is a good way to communicate to Terraform that these things could never be read back. Probably something like this could be a way to go: hashicorp/terraform-provider-awscc#86
I'll take a look on Monday.

I think I need to ask railway people to upgrade my account to Pro so that I can add tests for this and support it.

Ok, got it!

@wertlex
Copy link
Contributor Author

wertlex commented May 27, 2024

I have to check if there is a good way to communicate to Terraform that these things could never be read back. Probably something like this could be a way to go: hashicorp/terraform-provider-awscc#86 I'll take a look on Monday.

I did a quick check, so there is no special actions required to preserve source_image_private_registry_password value, since it is already performed here and never overwritten.

@pksunkara pksunkara removed the W: other Waiting: Other issues label Jul 15, 2024
@pksunkara pksunkara merged commit 00dc8ae into terraform-community-providers:master Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C: service Context: Service D2: medium Difficulty: Medium to implement T: feature Type: Feature request U2: nice to have Urgency: Nice to have

Development

Successfully merging this pull request may close these issues.

2 participants