Warning: Deprecated attribute - The attribute "name" is deprecated

[todd-dsm]

Description

I'm getting this error recently:

Warning: Deprecated attribute

  on .terraform/modules/network.vpc/vpc-flow-logs.tf line 28, in locals:
  28:     "arn:${data.aws_partition.current[0].partition}:logs:${data.aws_region.current[0].name}:${data.aws_caller_identity.current[0].account_id}:log-group:${log_group.name}:*"

The attribute "name" is deprecated. Refer to the provider documentation for
details.

As an experiment, I tried it with that switch turned off

module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> 5.21.0"
...
  # Disable VPC Flow Logs to avoid the warning
  enable_flow_log = false

But, the message persists.

• ✋ I have searched the open/closed issues and my issue is not listed.

Versions

% terraform version 
Terraform v1.11.4
on darwin_arm64
+ provider registry.terraform.io/hashicorp/aws v6.0.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.37.1
+ provider registry.terraform.io/hashicorp/random v3.7.2

Reproduction Code [Required]

A quick experiment with EKS Auto Mode

####################################################################################
# VPC Network Resources
# VER: https://github.com/terraform-aws-modules/terraform-aws-vpc/releases
# TFR: https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/latest
# GHR: https://github.com/terraform-aws-modules/terraform-aws-vpc/tree/master/examples
####################################################################################
module "vpc" {
  source  = "terraform-aws-modules/vpc/aws"
  version = "~> 5.21.0"

  name            = var.project
  cidr            = var.vpc_cidr
  azs             = var.azs
  private_subnets = [for k, v in var.azs : cidrsubnet(var.vpc_cidr, 3, k)]
  public_subnets  = [for k, v in var.azs : cidrsubnet(var.vpc_cidr, 3, k + 3)]

  enable_nat_gateway     = true
  single_nat_gateway     = true
  create_egress_only_igw = true
  enable_dns_hostnames   = true
  enable_dns_support     = true

  # IPv6 Support
  # enable_ipv6                                    = true
  # public_subnet_ipv6_prefixes                    = [0, 1, 2]
  # public_subnet_assign_ipv6_address_on_creation  = false
  # private_subnet_ipv6_prefixes                   = [3, 4, 5]
  # private_subnet_assign_ipv6_address_on_creation = false

  # Disable VPC Flow Logs to avoid the warning
  enable_flow_log = false


  # Tag Subnets: Public
  public_subnet_tags = merge(var.tags, {
    Name                     = "${var.project}-public"
    Module                   = "networking"
    "kubernetes.io/role/elb" = 1
  })

  # Tag Subnets: Private
  private_subnet_tags = merge(var.tags, {
    Name                              = "${var.project}-private"
    Module                            = "networking"
    "kubernetes.io/role/internal-elb" = 1
    "karpenter.sh/discovery"          = var.project
  })

  # Tag VPC
  tags = merge(var.tags, {
    Name                     = "${var.project}-vpc"
    Module                   = "networking"
    "karpenter.sh/discovery" = var.project
  })
}

Steps to reproduce the behavior:

Happy path: init, plan

Expected behavior

Expected output: This message does not display.

[antonbabenko]

This issue has been resolved in version 5.21.1 🎉

[Roberdvs]

Hi @antonbabenko !

The PR with the fix has introduced a breaking change.

aws_region data source on AWS Provider v5 doesn't contain a region attribute. Seems it was introduced in v6

So now you don't get the deprecation warning when running on v6, but you get an error when running on v5, which can only be fixed by pinning a previous version of the module or upgrading the AWS provider to v6:

│ Error: Unsupported attribute
│ 
│   on .terraform/modules/vpc/vpc-flow-logs.tf line 28, in locals:
│   28:     "arn:${data.aws_partition.current[0].partition}:logs:${data.aws_region.current[0].region}:${data.aws_caller_identity.current[0].account_id}:log-group:${log_group.name}:*"
│ 
│ This object has no argument, nested block, or exported attribute named "region"

Edit: The deprecation warning only shows when running on AWS Provider v6

[todd-dsm]

FYI: Unless I misunderstood, I haven't moved to v6 yet; I'm getting this late in v5.99.1

Low priority though, the message is only annoying and can safely be ignored.

% terraform plan
...
Plan: 14 to add, 0 to change, 0 to destroy.

Warning: Deprecated attribute

  on .terraform/modules/network.vpc/vpc-flow-logs.tf line 28, in locals:
  28:     "arn:${data.aws_partition.current[0].partition}:logs:${data.aws_region.current[0].name}:${data.aws_caller_identity.current[0].account_id}:log-group:${log_group.name}:*"

The attribute "name" is deprecated. Refer to the provider documentation for
details.

(and one more similar warning elsewhere)

─────────────────────────────────────────────────────

Saved the plan to: /tmp/tf-gitops-demo.plan

To perform exactly these actions, run the following command to apply:
    terraform apply "/tmp/project.plan"

% cat provider.tf  
terraform {
  # https://github.com/hashicorp/terraform/releases
  required_version = "~> 1.11.4"
  required_providers {
    # https://github.com/hashicorp/terraform-provider-aws/releases
    aws = {
      source  = "hashicorp/aws"
      version = ">= 5.99.1"
    }
    # https://github.com/hashicorp/terraform-provider-kubernetes/releases
    kubernetes = {
      source  = "hashicorp/kubernetes"
      version = ">= 2.37.1"
    }
    # https://github.com/hashicorp/terraform-provider-random/releases
    random = {
      source  = "hashicorp/random"
      version = ">= 3.7.2"
    }
  }
  backend "s3" {
    use_lockfile = true
    bucket       = "bucket-name"
    key          = "bucket-key"
    region       = "us-east-1"
    encrypt      = true
  }
}

### The AWS Provider
# https://registry.terraform.io/providers/hashicorp/aws/latest/docs
provider "aws" {
  region = "us-east-1"
}

[todd-dsm]

I bumped the terraform-aws-modules/vpc/aws version: 5.21.1 > 6.0.1 in my build. The message is gone. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.