fix: Look up partition instead of hard-coded "aws" #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanivey
changed the title
alanivey
changed the title
alanivey
changed the title
alanivey
force-pushed
the
partition-fix
branch
from
d5d947c to
08fdf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the actual AWS partition for WAF log delivery policy instead of assuming "aws".
Motivation and Context
Allows WAF delivery (also works for VPC Flow Logs) policy to be used in other AWS partitions.
Breaking Changes
None, users on AWS commercial cloud will not have policies changed.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestAlso, I have deployed this in a GovCloud account and verified VPC Flow Log delivery occurs.