Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update default values for security posture improvement #369

Merged
merged 17 commits into from
Feb 16, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Dec 24, 2021

Description

For complete list of changes, please see upgrade guide https://github.com/bryantbiggs/terraform-aws-rds/blob/feat/updates/UPGRADE-4.0.md

Motivation and Context

Breaking Changes

  • Yes

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@bryantbiggs bryantbiggs changed the title feat: update default values for security posture improvement feat: Update default values for security posture improvement Jan 12, 2022
@bryantbiggs bryantbiggs changed the title feat: Update default values for security posture improvement feat!: Update default values for security posture improvement Jan 12, 2022
@bryantbiggs
Copy link
Member Author

@antonbabenko ps - it looks like their might be an issue with the token or something on the PR title check for this repo, not sure Error: Resource not accessible by integration

@antonbabenko antonbabenko changed the title feat!: Update default values for security posture improvement feat!: Update default values for security posture improvement (updated) Feb 15, 2022
@antonbabenko antonbabenko marked this pull request as ready for review February 15, 2022 16:18
@antonbabenko antonbabenko changed the title feat!: Update default values for security posture improvement (updated) feat!: Update default values for security posture improvement (updated 2) Feb 15, 2022
@antonbabenko antonbabenko marked this pull request as draft February 15, 2022 16:21
@antonbabenko
Copy link
Member

@antonbabenko ps - it looks like their might be an issue with the token or something on the PR title check for this repo, not sure Error: Resource not accessible by integration

I am not sure what can be the reason for this. I have not touched anything, it uses the default GITHUB_TOKEN. Probably some issues on the GitHub side.

@antonbabenko antonbabenko changed the title feat!: Update default values for security posture improvement (updated 2) feat!: Update default values for security posture improvement Feb 15, 2022
variables.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs marked this pull request as ready for review February 15, 2022 18:46
@antonbabenko antonbabenko merged commit 9149ec1 into terraform-aws-modules:master Feb 16, 2022
antonbabenko pushed a commit that referenced this pull request Feb 16, 2022
## [4.0.0](v3.5.0...v4.0.0) (2022-02-16)

### ⚠ BREAKING CHANGES

* Update default values for security posture improvement (#369)

### Features

* Update default values for security posture improvement ([#369](#369)) ([9149ec1](9149ec1))
@antonbabenko
Copy link
Member

This PR is included in version 4.0.0 🎉

@bryantbiggs bryantbiggs deleted the feat/updates branch February 16, 2022 12:18
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.