Skip to content

feat: Add support for creating CloudWatch log groups #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 6, 2023
Merged

feat: Add support for creating CloudWatch log groups #346

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
008e651
manage cloudwatch log groups
Dec 11, 2022
20e07dc
updates
Dec 17, 2022
bc91413
updates
Dec 17, 2022
dac5c66
update output naming
Dec 18, 2022
8a4f2aa
revert test
Dec 20, 2022
cac3fe3
fix: Update CI workflow to avoid hitting GitHub API rate limiting
bryantbiggs Jan 1, 2023
b8f1e67
fix: Revert versions till changes are made properly in #335
bryantbiggs Jan 1, 2023
ff3c89b
revert: Put CI workflow file back to original to see if we can get it…
bryantbiggs Jan 1, 2023
e61b364
Merge branch 'master' into feat/manage_cloudwatch_log_groups
magreenbaum Jan 28, 2023
5c04731
Merge branch 'master' into feat/manage_cloudwatch_log_groups
magreenbaum Feb 11, 2023
ae4703a
add conditional to prevent log group creation if using cluster name p…
Feb 12, 2023
a8c1bb8
add comment for clarity
Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ resource "aws_db_parameter_group" "this" {
################################################################################

resource "aws_cloudwatch_log_group" "this" {
for_each = toset([for log in var.enabled_cloudwatch_logs_exports : log if local.create_cluster && var.create_cloudwatch_log_group])
for_each = toset([for log in var.enabled_cloudwatch_logs_exports : log if local.create_cluster && var.create_cloudwatch_log_group && !var.cluster_use_name_prefix])
Copy link
Member Author

@magreenbaum magreenbaum Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated cloudwatch log group creation based on this feedback which is also relevant to this module.


name = "/aws/rds/cluster/${var.name}/${each.value}"
retention_in_days = var.cloudwatch_log_group_retention_in_days
Expand Down