- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 600
feat!: Terraform MSV increased to 1.0, consolidate security group rules under one generic resource, add support for managed master password #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            bryantbiggs
  merged 10 commits into
  terraform-aws-modules:master
from
bryantbiggs:chore/update-ci
  
      
      
   
  Apr 10, 2023 
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            10 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      e69dac2
              
                fix: Update CI configuration files to use latest version
              
              
                bryantbiggs 9462b7e
              
                fix: Update CI workflow to avoid hitting GitHub API rate limiting
              
              
                bryantbiggs 9ac6703
              
                chore: Update examples to align with current practices
              
              
                bryantbiggs 8b2a6c4
              
                chore: Add Upgrade guide and validate examples
              
              
                bryantbiggs 42312bd
              
                Merge branch 'master' into chore/update-ci
              
              
                bryantbiggs b1e0f39
              
                Merge branch 'master' into chore/update-ci
              
              
                bryantbiggs 560f6b1
              
                refactor: Replace random password generator with new managed password…
              
              
                bryantbiggs d80a81e
              
                Merge branch 'master' into chore/update-ci
              
              
                bryantbiggs f697c2d
              
                chore: Update upgrade guide
              
              
                bryantbiggs 0af5d45
              
                chore: Update to v4 of VPC module
              
              
                bryantbiggs File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: 'Lock Threads' | ||
|  | ||
| on: | ||
| schedule: | ||
| - cron: '50 1 * * *' | ||
|  | ||
| jobs: | ||
| lock: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: dessant/lock-threads@v3 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| issue-comment: > | ||
| I'm going to lock this issue because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues. | ||
| If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. | ||
| issue-inactive-days: '30' | ||
| pr-comment: > | ||
| I'm going to lock this pull request because it has been closed for _30 days_ ⏳. This helps our maintainers find and focus on the active issues. | ||
| If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. | ||
| pr-inactive-days: '30' | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to the PR, but I would like to know how to avoid GitHub token rate limit throttling since we have the same cron expression in all repositories, and every night I receive a lot of emails when this workflow fails.
There is an open issue already, but it doesn't seem to be moving anywhere - dessant/lock-threads#35