feat: Added appmesh controller support to iam-role-for-service-accounts-eks
#231
Conversation
yutachaos
force-pushed
the
feature/added_appmesh_support
branch
from
bb32e18 to
ca01916
Compare
yutachaos
force-pushed
the
feature/added_appmesh_support
branch
from
02ac93e to
0035366
Compare
bryantbiggs
left a comment
bryantbiggs
left a comment
There was a problem hiding this comment.
looks good, minor tweaks
let me know if you want to add in support for appmesh_envoy_proxy https://raw.githubusercontent.com/aws/aws-app-mesh-controller-for-k8s/master/config/iam/envoy-iam-policy.json in this PR, a separate PR, or I can add it in a PR as well.
|
@bryantbiggs |
bryantbiggs
left a comment
bryantbiggs
left a comment
There was a problem hiding this comment.
Looks great - thanks @yutachaos 🎉
## [4.21.0](v4.20.3...v4.21.0) (2022-04-22) ### Features * Added appmesh controller support to `iam-role-for-service-accounts-eks` ([#231](#231)) ([0492955](0492955))
|
This PR is included in version 4.21.0 🎉 |
|
|
||
| statement { | ||
| actions = [ | ||
| "arn:${local.partition}:iam::*:role/aws-service-role/appmesh.${local.dns_suffix}/AWSServiceRoleForAppMesh" |
There was a problem hiding this comment.
This is a resource when it should be actions
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
4 participants
Description
iam-role-for-service-accounts-eksMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request