feat: Add state to aws_cloudwatch_event_rule
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 2, 2023 09:18
…its true by the provider already and makes room for use of state
magreenbaum
commented
Dec 30, 2023
antonbabenko
approved these changes
Jan 12, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Jan 12, 2024
## [3.1.0](v3.0.1...v3.1.0) (2024-01-12) ### Features * Add `state` to `aws_cloudwatch_event_rule` ([#100](#100)) ([963753f](963753f))
|
This PR is included in version 3.1.0 🎉 |
|
@antonbabenko thank you for your effort and Slava Ukraini! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
statetoaws_cloudwatch_event_ruleand deprecatesis_enabled.Changed the default of
is_enabledtonullsince it is defaulttrueby the provider already and allows for the use ofstate.Motivation and Context
hashicorp/terraform-provider-aws#34510
Fixes #103
Breaking Changes
No. Left
is_enabledin place so it's backwards compatible.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request