Revert recent changes to aws-auth.tf

[dpiddockcmp]

PR o'clock

Description

This logic is broken. Looks like there's a Terraform bug related to not handling complex Object types. hashicorp/terraform#23562

Revert to the previous state instead of wiping out roles from aws-auth ConfigMaps.

See #606 (comment)

Another solution needs to be found for @shanmugakarna 's use case.

Checklist

• Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[shanxops]

@dpiddockcmp Looks like both my previous PRs messed up bigtime. Sorry

Another solution needs to be found for @shanmugakarna 's use case.

Does the below solution looks acceptable ?

%{if length(var.map_roles) != 0}${yamlencode(var.map_roles)}%{endif}

Ref:
#606
#611

[dpiddockcmp]

Yes, looks like length() works correctly with lists of complex objects 😄

[shanxops]

Thanks @dpiddockcmp . Create a new PR with length comparision
#619

[max-rocket-internet]

OK I've merged the other PR with fix. So I think we can close this one. Right?

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.