Skip to content

Conversation

@hodduc
Copy link
Contributor

@hodduc hodduc commented Nov 20, 2019

PR o'clock

Description

Fix issue #582. I followed suggestion here with some modification.

Also, I checked every AWS region to check existence of that image.

aws ec2 describe-images --owners 801119661308 --filters "Name=platform,Values=windows" "Name=name,Values=Windows_Server-2019-English-Core-EKS_Optimized-1.14-*" --region=$region | jq '.Images | .[] | [.Name, .ImageId, .CreationDate]'

Results: Windows_Server-2019-English-Core-EKS_Optimized-1.14-* AMI exists on all regions except ca-central-1 and us-west-1. But EKS is not available on ca-central-1 & us-west-1, so this is OK.

Checklist

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hodduc

@max-rocket-internet max-rocket-internet merged commit 215dc84 into terraform-aws-modules:master Nov 20, 2019
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants