Fix accidental background filling of config files #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like someone has accidentally backgrounded the calls to fill out kube_config.yaml and aws_auth_configmap.yaml I assume, and it makes sense to use double ampersand so that each command runs only if the previous one worked. Also might be able to remove the 10x loop depending on why that was added. If it was added because the code randomly worked/not then I have probably fixed that and removed the need for the loop
Contributor
|
Sorry @james-portman-contino I missed this PR 😐 It was addressed in #592 anyway. |
Author
|
OK brill, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
It looks like someone has accidentally backgrounded the calls to fill out kube_config.yaml and aws_auth_configmap.yaml
Using a single ampersand will run the echo commands in the background and immediately run kubectl (at the same time essentially) so the config files can/will often be empty
I assume, and it makes sense to use double ampersand so that each command runs only if the previous one worked.
Also might be able to remove the 10x loop depending on why that was added.
If it was added because the code randomly worked/not (not surprised) then I have probably fixed that and removed the need for the loop
Checklist
terraform fmtandterraform validateboth work from the root andexamples/*directories