feat: Match block_device_mappings with workers_launch_template in node group #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongdewen
changed the title
kongdewen
changed the title
1 task
|
This issue has been resolved in version 18.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/workers_launch_template.tf, the module support
root_block_device_nameas variable, and also added support foradditional_ebs_volumesandadditional_instance_store_volumes, It will be nice if we can match the same flexibility as we support node groups as now we are supporting custom AMI image.Motivation and Context
It starts with issue fix: #1714. Thought why don't we want to do more
Breaking Changes
N/A
How Has This Been Tested?
We have a batch version fixed the issue(#1714) deployed in our prod account.
for
additional_ebs_volumes,additional_instance_store_volumes, we don't have any usage yet, we only didterraform planfor test scenario.