feat: Add support for Managed Node Groups (node_groups) taints
#1424
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nauxliu
changed the title
nauxliu
force-pushed
the
feature/node-groups-taints
branch
2 times, most recently
from
f20a63d to
bf9ed60
Compare
1 task
barryib
changed the title
node_groups) taints
ArchiFleKs
approved these changes
Jun 2, 2021
barryib
reviewed
Jun 2, 2021
nauxliu
force-pushed
the
feature/node-groups-taints
branch
from
bf9ed60 to
dce64ae
Compare
barryib
approved these changes
Jun 3, 2021
|
Thanks again @nauxliu for your contribution. |
|
@barryib any idea when is this merge getting released? thank you :) |
|
+1 ^ |
1 task
|
Just released it in v17.1.0 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for set taints on managed node groups, Resolve #1403
Ref:
https://docs.aws.amazon.com/eks/latest/userguide/node-taints-managed-node-groups.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/eks_node_group#taint-configuration-block
Checklist