Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default for tag lookup in job queue resources. #2

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

mattaltberg
Copy link
Contributor

Description

The job queue and scheduling policy resources are missing the default values for the lookup function.

Motivation and Context

Without this change, you need to add tags specific to each job queue.

Breaking Changes

No

How Has This Been Tested?

  • [ x ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [ x ] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ x ] I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title Add default for tag lookup in job queue resources. fix: Add default for tag lookup in job queue resources. Jul 4, 2022
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @mattaltberg 🎉

@bryantbiggs bryantbiggs merged commit edb1b75 into terraform-aws-modules:master Jul 4, 2022
antonbabenko pushed a commit that referenced this pull request Jul 4, 2022
### [1.1.2](v1.1.1...v1.1.2) (2022-07-04)

### Bug Fixes

* Add default for tag lookup in job queue resources. ([#2](#2)) ([edb1b75](edb1b75))
@antonbabenko
Copy link
Member

This PR is included in version 1.1.2 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants