Skip to content

feat: Add support for private ca certs #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryantbiggs merged 2 commits into from
Jun 5, 2025
Merged

feat: Add support for private ca certs #155

bryantbiggs merged 2 commits into from
Jun 5, 2025

Conversation

@mrobinson1022
Copy link
Contributor

@mrobinson1022 mrobinson1022 commented Apr 8, 2025

Added support for private CA acm certificates

Description

Added the following attribute and corresponding variable:

certificate_authority_arn = var.private_authority_arn
variable "private_authority_arn" {
  description = "Private Certificate Authority ARN for issuing private certificates"
  type        = string
  default     = null
}

Motivation and Context

This allows the module to be used for private CA's to issue ACM certificates.

Breaking Changes

There should be no breaking change with this. The variable default is null so not having it declared should not result in any changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@mrobinson1022
feat: add support for private ca certs
00db4c9 
added example for private CA
@mrobinson1022 mrobinson1022 changed the title feat: add support for private ca certs feat: Add support for private ca certs Apr 8, 2025
@rsi-mrobinson
Copy link

rsi-mrobinson commented May 5, 2025

@bryantbiggs Let me know if you have any questions/changes for this PR

bryantbiggs
bryantbiggs requested changes Jun 4, 2025
View reviewed changes
.gitignore Outdated
# Ignore CLI configuration files
.terraformrc
terraform.rc
.qodo
Copy link
Member

@bryantbiggs bryantbiggs Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Contributor Author

@mrobinson1022 mrobinson1022 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

examples/private-ca-authority/main.tf Outdated
tags = local.tags
}

resource "aws_acmpca_certificate_authority" "root_ca" {
Copy link
Member

@bryantbiggs bryantbiggs Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are expensive - since this is a single attribute change, we can forgo the example in this case.

please remove the new example

Copy link
Contributor Author

@mrobinson1022 mrobinson1022 Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

main.tf
validation_method = var.validation_method
key_algorithm = var.key_algorithm

certificate_authority_arn = var.private_authority_arn
Copy link
Member

@bryantbiggs bryantbiggs Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is valid since v3.32 so no provider version bump required hashicorp/terraform-provider-aws#10213

@mrobinson1022
Copy link
Contributor Author

mrobinson1022 commented Jun 5, 2025

@bryantbiggs I made the requested updates

bryantbiggs
bryantbiggs approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit f5dffc6 into terraform-aws-modules:master Jun 5, 2025
9 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 5, 2025
@semantic-release-bot
chore(release): version 5.2.0 [skip ci]
61c702b 
## [5.2.0](v5.1.1...v5.2.0) (2025-06-05)

### Features

* Add support for private CA certificates ([#155](#155)) ([f5dffc6](f5dffc6))
@antonbabenko
Copy link
Member

antonbabenko commented Jun 5, 2025

This PR is included in version 5.2.0 🎉

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrobinson1022 @rsi-mrobinson @antonbabenko @bryantbiggs