Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade terra to v0.47.x #259

Merged
merged 5 commits into from
Aug 18, 2023
Merged

feat: upgrade terra to v0.47.x #259

merged 5 commits into from
Aug 18, 2023

Conversation

emidev98
Copy link

@emidev98 emidev98 commented Aug 15, 2023

Description

CosmosSDK upgrade to v0.47.x including Terra's changes. This upgrade contains mocks for vesting module generated with the following command:

mockgen -source x/auth/vesting/types/expected_keepers.go -destination x/auth/vesting/testutil/expected_keepers_mocks.go

EventTypeMessage events, with sdk.AttributeKeyModule and sdk.AttributeKeySender are now emitted directly at message excecution (in baseapp) which leads to removing the following lines of code and create breaking changes with the previous version because the vesting coins are not emitted anymore.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@emidev98 emidev98 changed the title Upgrade/v0.47.x feat: upgrade terra to v0.47.x Aug 15, 2023
x/auth/vesting/types/msgs.go Dismissed Show dismissed Hide dismissed
x/auth/vesting/types/msgs.go Dismissed Show dismissed Hide dismissed
@tuky191 tuky191 merged commit 6cf2102 into release/v0.47.x Aug 18, 2023
67 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants