Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P51: Scope.prototype.$$areEqual method does not need special case for NaN checks #333

Open
abdulapopoola opened this issue May 15, 2016 · 1 comment
Open

P51: Scope.prototype.$$areEqual method does not need special case for NaN checks #333

abdulapopoola opened this issue May 15, 2016 · 1 comment

Comments

@abdulapopoola
Copy link

The _.isEqual function already returns true for NaN values.
abdulapopoola added a commit to abdulapopoola/build-your-own-angularjs that referenced this issue May 15, 2016
@abdulapopoola
$$areEqual method does not need special case for NaN checks
39055c6 
See issue teropa#333
@abdulapopoola abdulapopoola mentioned this issue May 15, 2016
Open
@caolinjian
Copy link

When you check numbers .The flag valueEq will be false .So it won't go _.isEqual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abdulapopoola @caolinjian