WOQL.doc does not interpret arrays properly

[wcoolidge]

client.query(WOQL.insert_document(WOQL.doc( json-as-per-GeoPolygon-example)))

yields

"data": {
    "api:message": "Error: unrecognized_property(\"GeoPolygon\",coordinates,json{'0':json{'0': -6.3491535,'1':53.3700669},....

Note that the example json had to be changed (i.e. bug in doc) from "@id": "PhoenixPark" to "GeoPolygon/PhoenixPark" in both the above and the following:

client.addDocument( json-as-per-GeoPolygon-example) works 

Thanks to Fidelio for pointing this out.

To Reproduce
Schema:

{ 
    "@id"        : "GeoPolygon",
    "@type"      : "Class",
    "name"       : "xsd:string",
    "coordinates"    : 
    { 
        "@type"  : "Array",
        "@dimensions" : 2,
        "@class" : "xsd:decimal" 
    }
}

const json-as-per-GeoPolygon-example = 
= {
        "@id"           : "GeoPolygon/PhoenixPark",
        "@type"         : "GeoPolygon",
        "name"          : "The Pheonix Park",
        "coordinates"   :
        [
          [
            -6.3491535,
            53.3700669
          ],
          [
            -6.3364506,
            53.3717056
          ],
          [
            -6.349411,
            53.3699645
          ]
        ]
    };

client.query(WOQL.insert_document(WOQL.doc(const json-as-per-GeoPolygon-example)))

Expected behavior
insert succeeds and instance with array is available for query in db

Error logs

"data": {
    "api:message": "Error: unrecognized_property(\"GeoPolygon\",coordinates,json{'0':json{'0': -6.3491535,'1':53.3700669},....

System information (please complete the following information):

• OS: Ubuntu 20.04
• NodeJS version 14.19.1
• terminus-client 10.0.10
• terminusdb 10.0.25
• typescript 4.6.2

[spl]

Thanks for the report!

I wanted to try this with our new command-line doc commands to see what happens. I believe everything is working there as expected.

$ jq . schema.json 
{
  "@id": "GeoPolygon",
  "@type": "Class",
  "name": "xsd:string",
  "coordinates": {
    "@type": "Array",
    "@dimensions": 2,
    "@class": "xsd:decimal"
  }
}
$ jq . instance.json 
{
  "@id": "GeoPolygon/PhoenixPark",
  "@type": "GeoPolygon",
  "name": "The Pheonix Park",
  "coordinates": [
    [
      -6.3491535,
      53.3700669
    ],
    [
      -6.3364506,
      53.3717056
    ],
    [
      -6.349411,
      53.3699645
    ]
  ]
}
$ ./terminusdb db create issue188
Database admin/issue188 created
$ ./terminusdb doc insert admin/issue188 --graph-type=schema < schema.json 
Document(s) inserted: 1
$ ./terminusdb doc insert admin/issue188 < instance.json 
Document(s) inserted: 1
$ ./terminusdb doc get admin/issue188 --graph_type=schema | jq .
{
  "@base": "terminusdb:///data/",
  "@schema": "terminusdb:///schema#",
  "@type": "@context"
}
{
  "@id": "GeoPolygon",
  "@type": "Class",
  "coordinates": {
    "@class": "xsd:decimal",
    "@dimensions": 2,
    "@type": "Array"
  },
  "name": "xsd:string"
}
$ ./terminusdb doc get admin/issue188 | jq .
{
  "@id": "GeoPolygon/PhoenixPark",
  "@type": "GeoPolygon",
  "coordinates": [
    [
      -6.3491535,
      53.3700669
    ],
    [
      -6.3364506,
      53.3717056
    ],
    [
      -6.349411,
      53.3699645
    ]
  ],
  "name": "The Pheonix Park"
}

[spl]

I'm seeing funny things with the command-line query with WOQL.

$ ./terminusdb query admin/issue188 "insert_document(_{'@type':"GeoPolygon"})"
GeoPolygon
sys:Top
Inserts: 1
$ ./terminusdb doc get admin/issue188 

There appear to be problems in core. I'm moving the issue there.

[spl]

So, the above example was partially a problem with my WOQL. It treated GeoPolygon as a variable. An equivalent query is this:

./terminusdb query admin/issue188 "insert_document(_{'@type':v('GeoPolygon')})"

If I make sure GeoPolygon is actually a string, then I get this:

$ ./terminusdb query admin/issue188 "insert_document(_{'@type':\"GeoPolygon\"})"
Error: There was an error when schema checking
{
  "@type":"api:WoqlErrorResponse",
  "api:error": {
    "@type":"api:WOQLSchemaCheckFailure",
    "api:witnesses": [
      {
	"@type":"required_field_does_not_exist_in_document",
	"document": {
	 "@type":"terminusdb:///schema#GeoPolygon",
	 "terminusdb:///schema#coordinates": {
	   "@container":"@array",
	   "@dimensions":2,
	   "@type":"http://www.w3.org/2001/XMLSchema#decimal",
	   "@value": []
	 }
	},
	"field":"terminusdb:///schema#name"
      }
    ]
  },
  "api:message":"There was an error when schema checking",
  "api:status":"api:failure"
}

[spl]

Okay, I figured out how to insert it using the command line:

$ ./terminusdb query admin/issue188 "insert_document(_{'@type':\"GeoPolygon\",'coordinates':[[-6.3491535,53.3700669]],'name':\"i am here\"})"
No results
Inserts: 12

$ ./terminusdb doc get admin/issue188 | jq .
{
  "@id": "GeoPolygon/f3c7cf65243b1c21f64ecb440b668682f157eb7f86d215bb5da9d1e30e1fd8d8",
  "@type": "GeoPolygon",
  "coordinates": [
    [
      -6.3491535,
      53.3700669
    ]
  ],
  "name": "i am here"
}

[spl]

Okay, transferred back to terminusdb-client-js since it now seems like this is a problem with WOQL.doc and arrays.