Fixed bug in sendNotificationMessage Hook processing

[Defcon0]

The object had never been called in the former implementation

[aschempp]

Looks good to me.

[Toflar]

1. If importStatic() then obviously System::importStatic(), not Controller::importStatic().
2. @dmolineus: As this was your contribution, do you want to check this?

[dmolineus]

@Toflar I can't reproduce why the previous implementation does not work. It works pretty fine here. But I don't mind using the importStatic method here.

[Defcon0]

That would be great. If you need another reason ro use the proposed solution, it's contaos standard way to handle hook calls.

[Toflar]

So I can close this, right? It's not a bug and importStatic is actually not a good choice anyway.

[Defcon0]

Why isn't importStatic a good choice? In addition I didn't see the way it's implemented right now in the whole core before.

[Toflar]

Why isn't importStatic a good choice?

Because it's a useless dependency on System and I never understood what it should be good for :)

[dmolineus]

Just thought about it one more time. The current implementation won't work with classes using the getInstance singleton "standard" of Contao. But that could be a known limitation. ;)

[Toflar]

Uff, okay then we could change it (even though I don't like it) but not Controller:: but System:: instead.

[Defcon0]

Mhm, I just gave it another try and it simply doesn't work. call_user_func doesn't call the created object's method. Would be kind, if someone could try to reproduce it with the module which doesn't work with the current implementation. It's one of our modules: https://github.com/heimrichhannot/contao-notification_center_plus (also available via composer). It adds css inlining and an additional salutation shorthand token. And addTokens in assigned as a hook in config.php doesn't work. When importing it static in the way I described above, it works like a charm.