Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow recipient token to contain a list of recipients. #75

Merged

Conversation

dmolineus
Copy link
Contributor

This pull request adds the feature that a token can contain a list of recipients (See #71).

Why is it useful: Image you have an product where users add comments. Each user who added a comment can subscribe for changes. So when a new comment is added, only one notification can be sent containing a message to the admin and the message for the subscribers.

Toflar added a commit that referenced this pull request Sep 3, 2015
…token

Allow recipient token to contain a list of recipients.
@Toflar Toflar merged commit a93f70f into terminal42:develop Sep 3, 2015
@dmolineus dmolineus deleted the feature/multiple-recipients-in-token branch September 3, 2015 12:53
@Toflar Toflar added this to the 1.3.0 milestone Sep 3, 2015
@aschempp
Copy link
Member

aschempp commented Sep 3, 2015

In this case the second recursiveReplaceTokensAndTags does not really make sense to me?

@dmolineus
Copy link
Contributor Author

@aschempp Yes, you're right as the tokens are replaced recursively. Missed it the first time.

aschempp added a commit that referenced this pull request Sep 6, 2015
@aschempp
Copy link
Member

aschempp commented Sep 6, 2015

Changed in 054d6f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants