feat: bundle field definitions from required input packages#2
Draft
teresaromero wants to merge 3 commits into3279-merge-variables-when-required-inputfrom
Draft
feat: bundle field definitions from required input packages#2teresaromero wants to merge 3 commits into3279-merge-variables-when-required-inputfrom
teresaromero wants to merge 3 commits into3279-merge-variables-when-required-inputfrom
Conversation
This was referenced Mar 24, 2026
ea28eab to
e03e531
Compare
…ifests Implements variable merging as part of the required_inputs build step (issue elastic#3279). Input package vars are the base; composable package overrides win when explicitly specified. Promoted input-level vars and data-stream-level vars are correctly placed in the merged manifest. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When building composable integration packages, field definitions from required input packages are now bundled into the integration's data stream fields directories. Fields already defined in the integration take precedence; only fields absent from the integration are copied from the input package into a new file named <inputPkgName>-fields.yml. Closes elastic#3280 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3d7629c to
72eb9ef
Compare
Remove duplicate mergeVariables call in Bundle. Document Resolver, Bundle, RequiredInputsResolver, and NewRequiredInputsResolver to match the full pipeline (templates, variables, data stream fields). Broaden the no-requires debug log. Use Bundle in fields_test. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle field definitions from required input packages
Closes elastic#3280
Summary
Extends the required-inputs build step to bundle field definitions from required input packages into the composable integration's data streams.
Bundling rules:
<inputPkgName>-fields.ymlinside the data stream'sfields/directory, keeping integration-owned field files untouched.What changed
internal/requiredinputs/fields.go(new, ~200 lines)BundleFields: entry point called as part of the required-inputs build step.internal/requiredinputs/fields_test.go(new, ~300 lines)test/manual_packages/required_inputs/(new fixtures)fields_input_pkg— input package with a set of base field definitions.with_field_bundling— integration that declares a subset of fields, expecting the rest to be bundled in.How to test
Dependencies