Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't remove ignored provides. #46

Merged
merged 1 commit into from
Jun 18, 2014
Merged

Don't remove ignored provides. #46

merged 1 commit into from
Jun 18, 2014

Conversation

ama-ch
Copy link
Collaborator

@ama-ch ama-ch commented Jun 18, 2014

README.md says:

fixclosure doesn't remove any goog.provide and goog.require with this hint.

but fixclosure removes ignored goog.provides.

@ama-ch ama-ch changed the title Don't remove ignored goog.provides. Don't remove ignored provides. Jun 18, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) when pulling 2c77b8f on ama-ch:insert-ignored-provides into d33a408 on teppeis:master.

teppeis added a commit that referenced this pull request Jun 18, 2014
@teppeis
Merge pull request #46 from ama-ch/insert-ignored-provides
950b3da 
Don't remove ignored provides.
@teppeis teppeis merged commit 950b3da into teppeis:master Jun 18, 2014
@teppeis
Copy link
Owner

teppeis commented Jun 18, 2014

nice catch!

@ama-ch ama-ch deleted the insert-ignored-provides branch June 18, 2014 20:28
@ama-ch
Copy link
Collaborator Author

ama-ch commented Jun 18, 2014

Thank you 😋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ama-ch @coveralls @teppeis