Skip to content

Feature: limited datatypes #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

Feature: limited datatypes #374

wants to merge 25 commits into from

Conversation

mcb5637
Copy link
Collaborator

@mcb5637 mcb5637 commented Jun 5, 2025 •
edited by liss-h
Loading

close #369

TODO:

@mcb5637 mcb5637 changed the title Feature/limited datatypes Feature: limited datatypes Jun 5, 2025
This was linked to issues Jun 11, 2025
Feature: make ap datatypes replacable with non-ap counterparts #94
Closed
Some operations on xsd:Integer are unecessarily expensive #336
Open
@mcb5637 mcb5637 marked this pull request as ready for review June 11, 2025 12:48
@mcb5637 mcb5637 requested a review from liss-h June 11, 2025 12:48
liss-h
liss-h requested changes Jun 12, 2025
View reviewed changes
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First mini review: I didn't really look at anything, but the one thing I noticed is that you added an option to stay unlimited.

For the benefit of maintenance we should only support the limited integers.

Sorry that we weren't clear enough on that

@mcb5637 mcb5637 removed a link to an issue Jun 16, 2025
Feature: make ap datatypes replacable with non-ap counterparts #94
Closed
@mcb5637 mcb5637 requested a review from liss-h June 16, 2025 14:55
liss-h
liss-h requested changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is the first review. I'll review again after the changes have been made.

@mcb5637 mcb5637 requested a review from liss-h June 27, 2025 12:39
@mcb5637 mcb5637 mentioned this pull request Jul 3, 2025
Open
liss-h
liss-h requested changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I have some more comments

@mcb5637 mcb5637 requested a review from liss-h July 4, 2025 13:54
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@liss-h liss-h added the blocked This is blocked by something else label Jul 17, 2025
@liss-h
Copy link
Collaborator

liss-h commented Jul 17, 2025

blocked by BETA

liss-h
liss-h requested changes Jul 28, 2025
View reviewed changes
Copy link
Collaborator

@liss-h liss-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some additional parsing tests for Int128 (mostly larger numbers, or large negative numbers) so that we can be sure that it actually works correctly

mcb5637 added 3 commits August 4, 2025 15:05
@mcb5637
Merge branch 'develop' into feature/limited_datatypes
f1242d5 
# Conflicts:
#	src/rdf4cpp/BigDecimal.hpp
#	src/rdf4cpp/datatypes/registry/util/CharConvExt.hpp
@mcb5637
fix merge, assert
5dda0b3
@mcb5637
more tests, bugfix
5f5b47b
@mcb5637 mcb5637 requested a review from liss-h August 4, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liss-h liss-h Awaiting requested review from liss-h

Assignees

No one assigned

Labels

blocked This is blocked by something else

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add size limits for unlimited datatypes Some operations on xsd:Integer are unecessarily expensive

2 participants

@mcb5637 @liss-h