Added support for scalars in tt-xla #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajakovljevicTT
requested review from
kmitrovicTT and
mrakitaTT
as code owners
kmitrovicTT
reviewed
Dec 4, 2024
kmitrovicTT
approved these changes
Dec 4, 2024
|
@AleksKnezevic do you have the time to take a look, interested in your opinion. Thanks! |
AleksKnezevic
approved these changes
Dec 4, 2024
mrakitaTT
requested changes
Dec 4, 2024
mrakitaTT
reviewed
Dec 10, 2024
kmitrovicTT
reviewed
Dec 11, 2024
src/common/api_impl.cc
Outdated
There was a problem hiding this comment.
FYI You are gonna hit a conflict after rebase since submit API has been updated.
There was a problem hiding this comment.
Thanks for the heads up! Rebased successfully in order to check tests now.
ajakovljevicTT
force-pushed
the
ajakovljevic/support_scalars_in_xla
branch
from
763ad91 to
65ece7a
Compare
mrakitaTT
approved these changes
Dec 12, 2024
ajakovljevicTT
force-pushed
the
ajakovljevic/support_scalars_in_xla
branch
from
65ece7a to
91045ee
Compare
ajakovljevicTT
force-pushed
the
ajakovljevic/support_scalars_in_xla
branch
from
91045ee to
5a95bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that scalars are not supported in our TTIR dialect and instead promoted to tensors during StableHLO->TTIR conversion, the PJRT runtime did not now that return values of jax functions were scalars and not 1x1 tensors. This led to the behaviour of the python calls differing between CPU and Silicon calls, with CPU calls returning scalars as expected, and Silicon jax calls returning 1x1 tensors.
This necessitated a workaround reshaping in the test infra, and additionally did not match with that the end user of the jax framework expected. This PR fixes that, by adding tracking of scalars on the PJRT runtime side.
Fixes issue #81