Add CCL ops to TTNN dialect (#700) #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfengTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
nobradovictt,
jserbedzijaTT,
nsmithtt,
mrakitaTT and
tapspatel
as code owners
|
looks really good! Can we get a reduce scatter .mlir file in this PR as well? and silicon test cases for both all gather and reduce scatter. Check: https://docs.tenstorrent.com/tt-mlir/ttrt.html#generate-a-flatbuffer-file-from-compiler |
tapspatel
requested changes
Oct 17, 2024
gfengTT
force-pushed
the
gfeng/add-ttnn-ccl-ops
branch
2 times, most recently
from
0014b78 to
0cab785
Compare
nsmithtt
reviewed
Oct 22, 2024
gfengTT
force-pushed
the
gfeng/add-ttnn-ccl-ops
branch
from
501206d to
006812d
Compare
nsmithtt
approved these changes
Oct 23, 2024
gfengTT
force-pushed
the
gfeng/add-ttnn-ccl-ops
branch
from
006812d to
d28c320
Compare
gfengTT
force-pushed
the
gfeng/add-ttnn-ccl-ops
branch
from
d28c320 to
406d04e
Compare
tapspatel
approved these changes
Oct 24, 2024
These ops are addead: - all_gather - reduce_scatter Also add all_gather as a TTIR op
gfengTT
force-pushed
the
gfeng/add-ttnn-ccl-ops
branch
from
406d04e to
416d8ee
Compare
kmabeeTT
approved these changes
Oct 25, 2024
sdjordjevicTT
approved these changes
Oct 25, 2024
|
Looks like |
@svuckovicTT Yes. #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ops are addead:
Also add all_gather as a TTIR op
Closed #700