Use op.operation.name to detect funcOps in tt-explorer #2352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
In previous PR, I was not properly checking for funcOps to avoid extraneous node in tt-explorer (because
op.name
will yield actual func name,op.operation.name
will yield expected "func.func"). This is trivial fix to correct this logic, plus simplify call structure a bit based on Vraj's feedbackWhat's changed
Inlined one of the funcs I created, since it is only invoked once anyway + didn't add much clarity. Replaced relevant comparisons to "func.func" with
op.operation.name
instead ofop.name
Checklist