Implement OpModel interface for TTNN.MultiplyOp #2349
+392
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation for GetOpConstraints & GetOpRuntime for MultiplyOp. Unit tests for MultiplyOp API, unified with existing AddOp tests.
rpavlovicTT
requested review from
odjuricicTT,
tt-mpantic,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT,
jnie-TT and
azecevicTT
as code owners
svuckovicTT
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #2277
Problem description
Optimizer needs constraints and runtime model for every op in order to shard them properly. This commit adds support for multiply op in that regard.
What's changed
Implementation for GetOpConstraints & GetOpRuntime for MultiplyOp.
Unit tests for MultiplyOp API, unified with existing AddOp tests.
Checklist