Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2133: Modified existing golden functionality code to support multi-device tensors for CCL operations #2163

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tapspatel
Copy link
Collaborator

@tapspatel tapspatel commented Feb 10, 2025

Golden functionality currently only supports matching single device tensors. This change is step 1 to get the golden infrastructure ready to store per device tensors in the golden map as well as get the device tensors per device in runtime.

The following APIs are changed

op_golden_tensor_map = binary.get_debug_info_golden(loc)

{
device : golden_tensor
}
op_output_tensor_map = ttrt.runtime.get_op_output_tensor(op_context, program_context)

{
device: device_tensor
}

@vprajapati-tt
Copy link
Contributor

Yo @tapspatel I think I have some conflicting changes in #2136, we should try and coordinate a strategy for this.

@tapspatel
Copy link
Collaborator Author

@vprajapati-tt no worries, feel free to merge yours and I'll rebase on-top of it. I approved your PR

@tapspatel
Copy link
Collaborator Author

keeping this PR open but in draft and this is not the approach we want to take right now

@tapspatel tapspatel marked this pull request as draft February 21, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify existing golden infrastructure for multi-device tensors
2 participants