Add async ttnn parameter in open device #1802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnie-TT
requested review from
tapspatel,
nsmithtt,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
kmabeeTT
approved these changes
Jan 16, 2025
|
Can you add some test coverage for async mode? |
jnie-TT
force-pushed
the
jnie/async_ttnn_param
branch
4 times, most recently
from
410c444 to
791e124
Compare
jnie-TT
force-pushed
the
jnie/async_ttnn_param
branch
from
791e124 to
571e375
Compare
kmabeeTT
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Can we better differentiate between async on/off? Right now hard/impossible to tell which is which in two different views. async_on async_off might be better labels than some positional ON or OFF - and then something in text to address the second image here plz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move async mode flag from debug env to a parameter to open device.
FYI @AleksKnezevic