Fix Post From-Device Copy Processing Issue #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctodTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT,
nsmithtt,
tapspatel and
vprajapati-tt
as code owners
tapspatel
approved these changes
Jan 15, 2025
vprajapati-tt
approved these changes
Jan 15, 2025
jnie-TT
approved these changes
Jan 15, 2025
`ceil` was accidentally bound to `torch.log`. Now it is bound to `torch.ceil` as expected
This change fixes an issue with processing output tensors after they are pulled off the device when checking golden-ness. The resulting tensor had the first 32 bytes overwritten with seemingly uninitialized memory, resulting in nondeterministic failures during similarity checks. Now, the unadulterated tensor is returned. Fixes #1795
ctodTT
force-pushed
the
ctod/fix-device-copy-cast
branch
from
0b18496 to
e61cd66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue with processing output tensors after they are pulled off the device when checking golden-ness. The resulting tensor had the first 32 bytes overwritten with seemingly uninitialized memory, resulting in nondeterministic failures during similarity checks. Now, the unadulterated tensor is returned.
This change also fixes a minor bug relating to the binding of
ceil, as well as includes a convenience change to.gitignore, ignoring top level.mlirfiles often used during debugging.Fixes #1795