Support for uints in constant op #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmitrovicTT
requested review from
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT and
azecevicTT
as code owners
svuckovicTT
approved these changes
Jan 15, 2025
kmitrovicTT
force-pushed
the
kmitrovic/temp
branch
from
c7ed7b2 to
876d169
Compare
mmanzoorTT
approved these changes
Jan 15, 2025
kmitrovicTT
force-pushed
the
kmitrovic/temp
branch
2 times, most recently
from
491cd54 to
b5c028f
Compare
kmitrovicTT
force-pushed
the
kmitrovic/temp
branch
from
b5c028f to
4e199b7
Compare
kmitrovicTT
commented
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for unsigned ints in translation of constant op in stablehlo -> ttir and ttir -> ttnn passes.
I noticed it was missing after conducting some jax tests.