Add TTNN Dialect guidelines #1785
Conversation
svuckovicTT
requested review from
tt-mpantic,
sdjordjevicTT,
mtopalovicTT,
jserbedzijaTT and
azecevicTT
| @@ -0,0 +1 @@ | |||
| # TTNN Interactive Visualizer | |||
There was a problem hiding this comment.
mdbook auto-created this when I ran it. Looks like there's a link to this doc in SUMMARY.md but the doc didn't exist. @nsmith would you like me to remove the link and/or this newly added file?
There was a problem hiding this comment.
Do you mind removing the file? It's kind of hacky, but the interactive visualizer is already html so just by naming it correctly the SUMMARY.md generation ends up finding it. I think this MD would now generate new html that would clobber the interactive visualizer.
| OptionalAttr<FloatAttr>:$pad_value); | ||
| ``` | ||
|
|
||
| Mixing types and attributes within the ordering is **not** an issue, this is valid: |
There was a problem hiding this comment.
I'm not sure about "types and attributes", technically it should be "operands and attributes" if we follow the MLIR glossary, but "operands" is a bit overloaded, so I'm not sure what's the best term here.
There was a problem hiding this comment.
I see "operand" as a kind of higher level abstraction term, whereas Type and Attr are actual defined types in cpp, which is why I use those terms.
|
|
||
| There were very few issues with these previously, and they were caused by inconsistencies in TTNN lib APIs. | ||
|
|
||
| ### Attrs vs Types |
There was a problem hiding this comment.
I believe one important point about attrs is constness, if we can reasonably assume that some value will always be known in compile time, than it's probably a good candidate for attribute.
There was a problem hiding this comment.
Very good point, let me add that!
svuckovicTT
force-pushed
the
svuckovic/docs-ttnn-dialect
branch
from
cbc074d to
ba5f7fe
Compare
Following last year's last weekly tech talk, I'm adding docs on TTNN dialect contribution guidelines. This docs is a subset of the discussed doc - it doesn't include sections on generalizing ttnn->emitc conversions, and runtime ops.