Add l1 small size as an optional parameter to open device #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnie-TT
requested review from
tapspatel,
nsmithtt,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
tapspatel
approved these changes
Jan 14, 2025
LPanosTT
approved these changes
Jan 14, 2025
AleksKnezevic
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L1 small size is a device property and needs to be set when opening device, adding a parameter so that the user can toggle this as needed.
A future improvement would be to expose an API to the user to calculate the l1 small size directly, or maybe have a field in the device attr in the mlir that the compiler calculates and populates.
FYI @LPanosTT