Added temporary fix for breaking / new attributes in parser #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vprajapati-tt
commented
Jan 14, 2025
vprajapati-tt
commented
- This should help fix the issues seen in Enable viewing of llama prefill in tt-explorer #1769
- Simple fix to deal with new attributes that might break the system.
vprajapati-tt
requested review from
odjuricicTT,
tt-mpantic,
sdjordjevicTT,
nobradovictt and
vcanicTT
as code owners
odjuricicTT
requested changes
Jan 16, 2025
|
btw, I can confirm, with the fix proposed, I don't get the same error anymore. I can view parts of the model in explorer now. |
odjuricicTT
reviewed
Jan 21, 2025
| @@ -324,6 +324,9 @@ def parse_force(attr): | |||
| @AttrHandler.register_handler("dtype") | |||
| def parse_dtype(attr): | |||
| dtype = tt.ir.DataTypeAttr.maybe_downcast(attr) | |||
| if dtype is None: | |||
| # Potential for dtype to be StringAttr instead of tt.DataTypeAttr | |||
There was a problem hiding this comment.
Can we explicitly try to cast to StringAttr instead of checking for None?
There was a problem hiding this comment.
Checking for None is done to see if the above downcast failed, I changed it to explicitly cast to string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.