Enable choosing of input type for lowering tests #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctodTT
requested review from
nsmithtt,
tapspatel and
vprajapati-tt
as code owners
ctodTT
force-pushed
the
ctod/test-other-type-inputs
branch
from
ffe8e86 to
1e18da0
Compare
nsmithtt
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
This change looks great!
As for goldens and TTNN only supporting floats, since it will probably be this way for the foreseeable future, perhaps we should just store all goldens as type f32, regardless of the format.
Alternatively in the ttrt golden callback we could just automatically format covert the golden tensor into the same type as a the ttnn tensor.
Lmk what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the choosing of input types to generated MLIR and golden checks via
inputs_typeskwarg. Taketorch.dtypes as inputs, then converts them to MLIRTypes upon context introduction.Closes #1765