#1851: Add options to `ttmlir-translate` to output C++ from TTKernel dialect #1602

TT-billteng · 2024-12-15T07:43:58Z

Shardon requires emitting C++ from python kernels. To help with the testing and debug process, I've added a TTKernel to C++ target and options to ttmlir-translate to directly dump C++ from TTKernel dialect.

There are separate Noc and Tensix kernel dumping options because shardon users need to explicitly control the definition of Noc and Tensix kernels separately.

TT-billteng · 2024-12-28T08:16:56Z

lib/Conversion/TTKernelToEmitC/TTKernelToEmitC.cpp

+emitKernelAsCpp(mlir::ModuleOp op, llvm::raw_ostream &os, const ttkernel::ThreadType &threadType )
+{
+  std::vector<func::FuncOp> ops;
+  op->walk([&](func::FuncOp entry) {


Is there a better way to extract the nested FuncOp from ModuleOp?

TT-billteng · 2024-12-28T08:18:12Z

lib/Target/TTKernel/TTKernelToCppRegistration.cpp

+//TODO: Should generalize this to read kernel type from Attribute?
+void registerTensixKernelToCpp() {
+  TranslateFromMLIRRegistration reg(
+      "tensixkernel-to-cpp", "translate tensix kernel to C++",


Feel like I need to change the option to ttkernel-to-cpp=noc and ttkernel-to-cpp=tensix

Is this possible? If so, where can I find an example?

I only know how to do this using the -opt tool, the translate MLIR tool seems much less featureful in terms of CLI. Maybe we could do --ttkernel-to-cpp-tensix and --ttkernel-to-cpp-noc? It's probably OK the way you have it too.

I am more for what @nsmithtt suggested, it aligns better with the rest of the codebase:
--ttkernel-to-cpp-tensix
--ttkernel-to-cpp-noc

nsmithtt

Hey Bill, sorry I was on vacation, still catching up on reviews. This looks great a couple of minor nits and comments inline, but all optional.

nsmithtt · 2025-01-09T22:28:14Z

include/ttmlir/Target/TTKernel/TTKernelToCpp.h

+
+namespace mlir::tt::ttkernel {
+
+enum class ThreadType : uint32_t;


Nit: Should we include "ttmlir/Dialect/TTKernel/IR/TTKernelOpsTypes.h" instead of doing a forward declare? Would also prevent having an enum passed by reference.

OK let's do it since compile times aren't a concern here most likely

nsmithtt · 2025-01-09T22:37:18Z

lib/Target/TTKernel/TTKernelToCppRegistration.cpp

+//TODO: Should generalize this to read kernel type from Attribute?
+void registerTensixKernelToCpp() {
+  TranslateFromMLIRRegistration reg(
+      "tensixkernel-to-cpp", "translate tensix kernel to C++",


I only know how to do this using the -opt tool, the translate MLIR tool seems much less featureful in terms of CLI. Maybe we could do --ttkernel-to-cpp-tensix and --ttkernel-to-cpp-noc? It's probably OK the way you have it too.

nsmithtt · 2025-01-09T22:57:45Z

lib/Target/TTKernel/TTKernelToCppRegistration.cpp

+
+namespace mlir::tt::ttkernel {
+
+// TODO: Should generalize this to read kernel type from Attribute?


This is true too, we could attach an attribute to the func op via op->setDiscardableAttr.

I think the IR would like:

func.func @ttkernel_noc() -> () attributes { ttkernel.thread_type = #ttkernel.thread_type<tensix> } {

sdjordjevicTT

Just a few minor comments that I would like your follow up.

lib/Conversion/TTKernelToEmitC/TTKernelToEmitC.cpp

sdjordjevicTT · 2025-01-10T10:04:11Z

lib/Target/TTKernel/TTKernelToCppRegistration.cpp

+//TODO: Should generalize this to read kernel type from Attribute?
+void registerTensixKernelToCpp() {
+  TranslateFromMLIRRegistration reg(
+      "tensixkernel-to-cpp", "translate tensix kernel to C++",


I am more for what @nsmithtt suggested, it aligns better with the rest of the codebase:
--ttkernel-to-cpp-tensix
--ttkernel-to-cpp-noc

test/ttmlir/Translate/TTKernel/ttkernel_noc.mlir

svuckovicTT · 2025-01-15T16:01:17Z

include/ttmlir/Target/TTKernel/TTKernelToCpp.h

+
+// Translates a TTKernel operation to C++ and writes it to the given
+// stream.
+


nit: remove empty line

lib/Target/TTKernel/TTKernelToCpp.cpp

svuckovicTT · 2025-01-15T16:03:09Z

lib/Target/TTKernel/TTKernelToCppRegistration.cpp

+#include "mlir/Dialect/EmitC/IR/EmitC.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Tools/mlir-translate/Translation.h"
+
+#include "mlir/Dialect/SCF/IR/SCF.h"
+#include "ttmlir/Dialect/TT/IR/TT.h"
+#include "ttmlir/Dialect/TTKernel/IR/TTKernel.h"
+#include "ttmlir/Dialect/TTKernel/IR/TTKernelOpsTypes.h"
+#include "ttmlir/Target/TTKernel/TTKernelToCpp.h"
+#include <mlir/Dialect/MemRef/IR/MemRef.h>


https://docs.tenstorrent.com/tt-mlir/coding-guidelines.html#includes

…patch op

TT-billteng force-pushed the bteng/shardon_emitc branch 7 times, most recently from d77935c to 3a50482 Compare December 20, 2024 23:56

TT-billteng force-pushed the bteng/shardon_emitc branch from ecfef6c to fbd3a0d Compare December 28, 2024 06:53

TT-billteng changed the title ~~initial check-in~~ Add options to dump noc and tensix kernels directly to C++ Dec 28, 2024

TT-billteng commented Dec 28, 2024

View reviewed changes

TT-billteng changed the title ~~Add options to dump noc and tensix kernels directly to C++~~ Add TTKernel to C++ target and new options to ttmlir-translate Dec 28, 2024

TT-billteng changed the title ~~Add TTKernel to C++ target and new options to ttmlir-translate~~ Add new options to ttmlir-translate to output C++ from TTKernel dialect Dec 28, 2024

TT-billteng changed the title ~~Add new options to ttmlir-translate to output C++ from TTKernel dialect~~ Add options to ttmlir-translate to output C++ from TTKernel dialect Dec 28, 2024

TT-billteng marked this pull request as ready for review December 28, 2024 08:26

TT-billteng requested review from svuckovicTT, mtopalovicTT, nsmithtt and sdjordjevicTT as code owners December 28, 2024 08:26

TT-billteng force-pushed the bteng/shardon_emitc branch from 22391b4 to b608099 Compare January 1, 2025 02:54

nsmithtt approved these changes Jan 9, 2025

View reviewed changes

sdjordjevicTT requested changes Jan 10, 2025

View reviewed changes

TT-billteng force-pushed the bteng/shardon_emitc branch from 64553fd to d3c6898 Compare January 14, 2025 03:55

sdjordjevicTT approved these changes Jan 14, 2025

View reviewed changes

svuckovicTT approved these changes Jan 15, 2025

View reviewed changes

TT-billteng mentioned this pull request Jan 16, 2025

This is true too, we could attach an attribute to the func op via [op->setDiscardableAttr](https://mlir.llvm.org/doxygen/classmlir_1_1Operation.html#a55a7c816fbfdb0840b59c722b6020833). #1874

Open

TT-billteng added 4 commits January 16, 2025 22:06

initial check-in

e5406a7

use existing passes to translate kernel to C++

74e12fd

fix typo in filename

e48c6c1

fix compile error

850d371

TT-billteng added 20 commits January 16, 2025 22:06

CMake setup and fixing errors for TTKernelToCpp

92267fb

remove unused function parameter and fix error msg

aa1133e

add TTKernel translate MLIR testcases

f178591

rename emitDispatchOpRegionAsCpp function as it's not specific to Dis…

947004e

…patch op

register TT dialect

4e6ebf3

emit C++ with metal kernel boilerplate

c83e19c

cleanup

cf0474e

add python bindings to generate C++ for Noc and Tensix kernels

ee4776c

comment out printer

ae8a70a

fix linker error

1a27f16

update ttmlir-translate options in mlir test files

63b6978

remove KernelConfigInterface member variable

e23a520

remove debug code

1b5033a

remove python pass, change deferred to a later PR

4f96d52

cleanup

c8729d8

clang format

726d1da

use smallvector

052025d

change name of mlir translate options

970fefb

add filecheck statements

dcf1a7e

include header rather than fwd declare

1e0a8c6

TT-billteng force-pushed the bteng/shardon_emitc branch from d3c6898 to 1e0a8c6 Compare January 16, 2025 22:07

TT-billteng added 4 commits January 16, 2025 22:37

fix header order and add bug # to TODO

63d5cbb

reorder headers

d6cba0b

reorder headers

cf69651

fix headers

d81f756

TT-billteng enabled auto-merge (squash) January 16, 2025 23:09

TT-billteng changed the title ~~Add options to ttmlir-translate to output C++ from TTKernel dialect~~ #1851: Add options to ttmlir-translate to output C++ from TTKernel dialect Jan 16, 2025

TT-billteng merged commit 5a4f508 into main Jan 17, 2025
19 checks passed

TT-billteng deleted the bteng/shardon_emitc branch January 17, 2025 00:19

TT-billteng mentioned this pull request Jan 17, 2025

MLIR C++ code generation #1851

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1851: Add options to `ttmlir-translate` to output C++ from TTKernel dialect #1602

#1851: Add options to `ttmlir-translate` to output C++ from TTKernel dialect #1602

TT-billteng commented Dec 15, 2024 •

edited

Loading

TT-billteng Dec 28, 2024

TT-billteng Dec 28, 2024 •

edited

Loading

nsmithtt Jan 9, 2025

sdjordjevicTT Jan 10, 2025

TT-billteng Jan 14, 2025

nsmithtt left a comment

nsmithtt Jan 9, 2025

TT-billteng Jan 14, 2025

nsmithtt Jan 9, 2025

nsmithtt Jan 9, 2025

sdjordjevicTT left a comment

sdjordjevicTT Jan 10, 2025

svuckovicTT Jan 15, 2025

TT-billteng Jan 16, 2025

svuckovicTT Jan 15, 2025

TT-billteng Jan 16, 2025


		namespace mlir::tt::ttkernel {

		enum class ThreadType : uint32_t;


		namespace mlir::tt::ttkernel {

		// TODO: Should generalize this to read kernel type from Attribute?


		// Translates a TTKernel operation to C++ and writes it to the given
		// stream.

#1851: Add options to ttmlir-translate to output C++ from TTKernel dialect #1602

#1851: Add options to ttmlir-translate to output C++ from TTKernel dialect #1602

Conversation

TT-billteng commented Dec 15, 2024 • edited Loading

Choose a reason for hiding this comment

TT-billteng Dec 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nsmithtt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sdjordjevicTT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

#1851: Add options to `ttmlir-translate` to output C++ from TTKernel dialect #1602

#1851: Add options to `ttmlir-translate` to output C++ from TTKernel dialect #1602

TT-billteng commented Dec 15, 2024 •

edited

Loading

TT-billteng Dec 28, 2024 •

edited

Loading